03week 1 #4
Open
03week 1 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousifS
reviewed
Aug 12, 2018
| do | ||
| { | ||
| /*swap player turn ? Does this make sence to execute*/ | ||
|
|
There was a problem hiding this comment.
logic is slightly off, you draw the board before and after each player plays.
There was a problem hiding this comment.
Better comments on the methods would have been nice.
yousifS
reviewed
Aug 12, 2018
| // your code goes here | ||
|
|
||
| return false; | ||
| // checking for Tie |
There was a problem hiding this comment.
This is not really checking for a tie, its just checking that every position is played.
Owner
Author
|
Do you have time to meet today before or after class?
…On Sun, Aug 12, 2018 at 2:46 AM yousifS ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In TicTacToe/TicTacToe.cs
<#4 (comment)>
:
> };
public static void Main()
{
do
{
+ /*swap player turn ? Does this make sence to execute*/
+
Better comments on the methods would have been nice.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AkbBWTXGTzC2n-NKhQVYbEp25AkLXb97ks5uP908gaJpZM4VxWMY>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.