test if test catches error #39
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
force-pushed
the
339
branch
6 times, most recently
from
a9b0c00 to
9c4cd31
Compare
jschwe
force-pushed
the
339
branch
5 times, most recently
from
2ff0ce3 to
4830b12
Compare
The PROFILE option is set via the properties and does not need to be passed through anymore. That this issue has not been reported yet indicates, that there are not too many users with older CMake versions.
When cross-compiling with clang, we need to set the compiler target. Previously we did not have any CI tests which cross-compile with clang
Building / Linking the cdylib requires us to specify a library which provides the extern C function.
Test cross-compiling with clang. This should catch the issue fixed in corrosion-rs#338. Closes corrosion-rs#339.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.