Skip to content

Conversation

@akarve1507
Copy link

Summary

This pull request introduces an initial monolithic CR–P0 steady Navier–Stokes solver.

Current contents

  • chapter2/monolithic_navierstokes_crp0.py — runnable solver with:
    • Crouzeix–Raviart (CR) velocity and DG–0 pressure formulation
    • Weak Nitsche boundary enforcement
    • Optional Picard iteration (with --stokes-only mode for testing)
    • Verified with DOLFINx Docker image

Work in progress

  • Markdown tutorial (.md) page will be added in a future commit
  • ParaView figures to be included later
  • Documentation and mkdocs.yml update pending

Status

Code compiles and runs successfully
Tutorial and visualization assets pending
Opened as a work-in-progress (WIP) PR in line with project guidelines

I kindly request feedback from the maintainers to ensure that the implementation aligns with the project’s coding standards and tutorial structure. I am happy to revise and improve this contribution based on your suggestions before completing the documentation and visualization components.

@akarve1507
Copy link
Author

Hello @jorgensd, I hope you are doing well.

I wanted to kindly follow up on this PR. When you have a moment, I would greatly appreciate any initial feedback or workflow approval, so that I can continue developing and refining the contribution.

Thank you very much for your time and consideration.

@jorgensd
Copy link
Owner

Hello @jorgensd, I hope you are doing well.

I wanted to kindly follow up on this PR. When you have a moment, I would greatly appreciate any initial feedback or workflow approval, so that I can continue developing and refining the contribution.

Thank you very much for your time and consideration.

Hi @akarve1507
I’ll try to have a look this week.

@akarve1507
Copy link
Author

Hi @jorgensd, I hope your week is going well.

I wanted to gently check in regarding this PR. Any feedback whenever you have time would be very helpful.

Thank you for your time.

@jorgensd
Copy link
Owner

jorgensd commented Dec 3, 2025

Hi @jorgensd, I hope your week is going well.

I wanted to gently check in regarding this PR. Any feedback whenever you have time would be very helpful.

Thank you for your time.

I think you should embed the markdown part within the tutorial.
As you see for most of the other tutorials, it reads with mathematics and code intertwined, to show the different relations within the code.

I have some other comments as well.

Copy link
Owner

@jorgensd jorgensd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, but a few things to consider along the way.

akarve1507 and others added 10 commits December 6, 2025 00:31
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants