-
Notifications
You must be signed in to change notification settings - Fork 78
WIP( Work in progress): add monolithic CR–P0 Navier–Stokes solver #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello @jorgensd, I hope you are doing well. I wanted to kindly follow up on this PR. When you have a moment, I would greatly appreciate any initial feedback or workflow approval, so that I can continue developing and refining the contribution. Thank you very much for your time and consideration. |
Hi @akarve1507 |
|
Hi @jorgensd, I hope your week is going well. I wanted to gently check in regarding this PR. Any feedback whenever you have time would be very helpful. Thank you for your time. |
I think you should embed the markdown part within the tutorial. I have some other comments as well. |
jorgensd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, but a few things to consider along the way.
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Summary
This pull request introduces an initial monolithic CR–P0 steady Navier–Stokes solver.
Current contents
chapter2/monolithic_navierstokes_crp0.py— runnable solver with:--stokes-onlymode for testing)Work in progress
.md) page will be added in a future commitmkdocs.ymlupdate pendingStatus
Code compiles and runs successfully
Tutorial and visualization assets pending
Opened as a work-in-progress (WIP) PR in line with project guidelines
I kindly request feedback from the maintainers to ensure that the implementation aligns with the project’s coding standards and tutorial structure. I am happy to revise and improve this contribution based on your suggestions before completing the documentation and visualization components.