Skip to content

Stack overflow error when opening large CSV files ("Maximum call stack size exceeded") #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xXLeoXxOne wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Stack overflow error when opening large CSV files ("Maximum call stack size exceeded") #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f0b746
Refactor to use reduce for max column calculation
xXLeoXxOne Jan 5, 2026
6e2b622
Refactor column count calculation in CsvEditorProvider
xXLeoXxOne Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions src/CsvEditorProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ class CsvEditorController {
const text = this.document.getText();
const result = Papa.parse(text, { dynamicTyping: false, delimiter: separator });
const data = result.data as string[][];
const numColumns = Math.max(...data.map(r => r.length), 0);
const numColumns = data.reduce((max, r) => Math.max(max, r.length), 0);
const newRow = Array(numColumns).fill('');
if (index > data.length) {
while (data.length < index) data.push(Array(numColumns).fill(''));
Expand All @@ -466,7 +466,7 @@ class CsvEditorController {
const text = this.document.getText();
const result = Papa.parse(text, { dynamicTyping: false, delimiter: separator });
const data = result.data as string[][];
const numColumns = Math.max(...data.map(r => r.length), 0);
const numColumns = data.reduce((max, r) => Math.max(max, r.length), 0);
for (let k = 0; k < count; k++) {
const newRow = Array(numColumns).fill('');
if (index > data.length) {
Expand Down Expand Up @@ -603,7 +603,7 @@ class CsvEditorController {
bodyData = data.slice(offset);
}
const visibleForWidth = headerFlag ? [headerRow, ...bodyData] : bodyData;
let numColumns = Math.max(...visibleForWidth.map(row => row.length), 0);
let numColumns = visibleForWidth.reduce((max, row) => Math.max(max, row.length), 0);
if (numColumns === 0) numColumns = 1; // ensure at least 1 column for the virtual row

const columnData = Array.from({ length: numColumns }, (_, i) => bodyData.map(row => row[i] || ''));
Expand Down Expand Up @@ -743,11 +743,7 @@ class CsvEditorController {
return true; // with only one row visible, lean toward header
}

const numColumns = Math.max(
headerRow.length,
...body.map(r => r.length),
0
);
const numColumns = body.reduce((max, r) => Math.max(max, r.length), Math.max(headerRow.length, 0));
const bodyColData = Array.from({ length: numColumns }, (_, i) => body.map(r => r[i] || ''));
const bodyTypes = bodyColData.map(col => this.estimateColumnDataType(col));
const headerTypes = Array.from({ length: numColumns }, (_, i) => this.estimateColumnDataType([headerRow[i] || '']));
Expand Down Expand Up @@ -856,7 +852,7 @@ class CsvEditorController {
// ───────────── Utilities ─────────────

private computeColumnWidths(data: string[][]): number[] {
const numColumns = Math.max(...data.map(row => row.length), 0);
const numColumns = data.reduce((max, row) => Math.max(max, row.length), 0);
const widths = Array(numColumns).fill(0);
for (const row of data) {
for (let i = 0; i < numColumns; i++){
Expand Down