Multiple fixes in osctrl-cli and osctrl-api
#769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javuto
added
osctrl-api
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements multiple fixes in the osctrl-cli and osctrl-api, primarily addressing authentication flow issues and improving test output readability.
- Fixes the API login endpoint to properly handle unauthenticated requests
- Adds URL parameter support to osctrl-cli for API login configuration
- Enhances API tester output with emoji-based test summary formatting
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/api_tester.py | Enhanced test summary with emoji formatting and added 404 as expected status for query endpoints |
| cmd/cli/main.go | Added URL flag parameter and fixed API initialization timing in login flow |
| cmd/api/main.go | Removed authentication middleware from login endpoint to allow unauthenticated access |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api_tester.pyosctrl-apiurlparameter toosctrl-cliwhen logging with the API