darklua.process files in place #26
Conversation
|
In my case this fixes the issue where the generated Roblox dist packages tries to resolve packages inside "luau_packages" when they are actually located in "roblox_packages". |
|
This was actually a bug introduced in #17 😬 |
|
Realized this change also makes it so files from build_files that are not present in the includes in the pesde.toml wont get copied into the dist target directory. |
| local destination = targetDir.path:join(buildFile) | ||
| local parent = destination:parent() | ||
| if parent then | ||
| fs.writeDir(parent) |
There was a problem hiding this comment.
Wasn't this written already in line 240 above?
There was a problem hiding this comment.
Well yes in most cases the parent dir for a build file would be the targetDir, but if you input "modules/something.luau" as a build file then the parent dir would be "modules". So that code just makes sure the modules dir exist under the targetDir before writing (as fs.copy requires it).
I resolved this in 64fc1e9 |
I've run tests on a local playground which seems to work fine. |
2 participants
This will change the current behaviour of processing the actual source files into the build output, and now processes the already existing copies of the source files instead with themselves as the output.
This avoids issues where darklua doesn't know what .luaurc file to pull configs from. Before it would pull them from the user's own .luaurc, but this pr will fix that and it will now use the .luaurc files generated by pesde-multitarget.