Lune v10 #25
Open
Lune v10 #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix require mode + sync upstream
Fix require mode sync
fix pesde install + optimize darklua.process calls
jiwonz
requested changes
Nov 6, 2025
Owner
There was a problem hiding this comment.
This file seems unnecessary, as it seems to be used only for the AsPath type. You just need to rebuild AsPath.
Contributor
Author
There was a problem hiding this comment.
Not quite sure I get what you mean?
I guess I could export only the AsPathType from the module but I don't really see a reason not to export the other types (I can't remove them if that's what you mean as they are used inside the AsPathType).
Owner
There was a problem hiding this comment.
Oh, sorry! I misread. I didn't realize building AsPath would be so much work.. I think we need to expose some kind of function that checks if it's AsPath in pathfs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15