Skip to content

Conversation

@jhurliman
Copy link
Owner

Switch from Travis CI to GitHub Actions CI, fix eslint and a few linter errors

@jhurliman jhurliman requested a review from Copilot May 8, 2025 04:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces Travis CI with GitHub Actions CI and addresses linter issues, including fixes to ESLint errors and updates to package dependencies.

  • Replaces Travis CI configuration with a new GitHub Actions workflow (.github/workflows/ci.yml)
  • Updates test assertions in TokenBucket tests for clearer error reporting
  • Upgrades ESLint-related dependencies and removes deprecated configuration files

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/TokenBucket.test.ts Refined test assertions for timing and improved code clarity
src/RateLimiter.ts Updated error message formatting
src/RateLimiter.test.ts Adjusted typecasting for interval validation
package.json Updated linting scripts and dependency versions
eslint.config.cjs Introduced a centralized ESLint configuration file
README.md Updated build badge to reflect GitHub Actions CI
.travis.yml Removed Travis CI configuration
.github/workflows/ci.yml Added GitHub Actions workflow configuration
.eslintrc.json, .eslintignore Removed legacy ESLint config/support files
Comments suppressed due to low confidence (1)

src/TokenBucket.test.ts:20

  • [nitpick] Consider using Date.now() instead of '+new Date()' for improved readability and clarity.
const duration = +new Date() - start;

@jhurliman jhurliman merged commit 4aa1b5a into main May 8, 2025
3 checks passed
@jhurliman jhurliman deleted the jhurliman/github-ci branch May 8, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants