forked from session-foundation/session-android
-
Notifications
You must be signed in to change notification settings - Fork 0
SES-4753 - Manage Admins (Promotion and leaving group) #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
3c8f429
ManageAdminsScreen and viewmodel
jbsession eb69ef5
Self selection toast
jbsession 694134d
Promote members viewmodel
jbsession 6517e4d
Manage admins and promote admins screens
jbsession e4b0dc1
Ui fixes
jbsession ff2ccd1
Sending and resending promotions
jbsession 22d04c7
Cleanup, moved operation to promote members screen
jbsession 9150cb0
initial admin leave group
jbsession 4791585
Fix crash on navigation
jbsession 129fbc2
Updated filtering for admins and members that can be promoted
jbsession 8dff199
option update qaTag
jbsession 63cf267
Updated toast, added negative color for negative dialog button
jbsession f64e7da
Simplified toasts
jbsession b6b3fb4
dismiss before showing the new dialog
jbsession 2f3723c
moved showToast to base viewmodel
jbsession 981220b
Fixed toast thread
jbsession 75a6979
Throw error in promoting
jbsession 801ccac
initial parent vm WIP
jbsession 03c2812
Auto navigate to promote members
jbsession f11e0f1
cleanup
jbsession 14ac400
Moved groupName into base vm
jbsession 601bc62
Has members flag fix
jbsession 94b748f
Merge branch 'ses-4753/invite-members' into ses-4753/manage-admins
jbsession 3c4e734
Added error strings
jbsession File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to update the qaTag above by creating a new one so QA can have automated tests linking to this button, because right now you are reusing the manage members one.