Skip to content

Conversation

@psineur
Copy link

@psineur psineur commented Mar 26, 2019

Old Mobile Safari (like iOS 9) doesn't support const keyword in strict mode and has no window.fetch either.

Changes:

  • Fix unhandled exceptions on import (es5 target + libs for Promise/Dom)
  • Add polyfill for window.fetch

Test plan:

  • using old iPad Mini with iOS 9.3.2 & webpack dev-server
  • load website (universal web/electron react-app) containing electron-ga, observe it's not loading - throws in rendered.bundle due to const keywords
  • apply changes, install electron-ga-psineur package
  • app should load now
  • network dev tools tab should have google-analytics.com/batch when events are sent

@psineur psineur changed the title tsconfig: target es5 to support old mobile safari Support old mobile safari Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant