-
Notifications
You must be signed in to change notification settings - Fork 56
Construct JSON path only on exceptional cases. #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guidobrei
wants to merge
5
commits into
jamsesso:main
Choose a base branch
from
guidobrei:fix/63-memory-allocation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrfwow
approved these changes
Nov 18, 2025
Author
magnarn
reviewed
Nov 26, 2025
Contributor
magnarn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is awesome!
Thanks for fixing it. I wish I had though of this when introducing the json path.
magnarn
approved these changes
Nov 27, 2025
Author
|
I've added additional tests to cover malformed expressions. |
Author
|
@jamsesso any chance we could fix the issue soon? |
marcozabel
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #63: Excessive object and memory allocations from string format operations during JSON logic evaluation.
Summary of Improvements
jsonPathConstruction:Now,
jsonPathis built only when exceptions are thrown, not on every evaluation step.String.format:Frequent string formatting—previously responsible for a large portion of memory allocation—is now minimized.
Refactored string handling within the evaluation logic for improved efficiency.
Memory profiles should reflect reduced object churn and overall improved allocation patterns.
The public interfaces have not been changed. The change should not break any dependent library.
Benefits
Dramatically reduces allocations related to string operations, easing runtime memory pressure.
Faster evaluations due to fewer expensive object and string operations.
Enhanced library stability and efficiency under heavy or high-throughput usage.
jsonPathremains available for error handling and diagnostics, but is computed only as needed.