Fix inline selected_kind parsing (issue #353) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystophny
force-pushed
the
fix/issue353-selected-kind
branch
from
2110ae5 to
99a5cfb
Compare
krystophny
force-pushed
the
fix/issue353-selected-kind
branch
from
99a5cfb to
60c0c54
Compare
The issue353_selected_kind example was missing Makefile.meson needed for Direct-C mode testing. Also updated run.py to search for any f90wrap_*.f90 file rather than hardcoding f90wrap_toplevel.f90, since Direct-C mode generates differently named wrapper files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes jameskermode#353.
Problem
integer(kind=selected_int_kind(9))andreal(kind=selected_real_kind(13,300))were parsed with a missing closing parenthesis, leading to invalid wrapper declarations:integer(selected_int_kind(9), intent(out) :: ireal(selected_real_kind(13,300), intent(out) :: aFix
)when the kind expression contains nested parentheses.Regression
examples/issue353_selected_kindthat runsf90wrapand asserts the generatedf90wrap_toplevel.f90contains:integer(selected_int_kind(9)), intent(out) :: ireal(selected_real_kind(13,300)), intent(out) :: aEvidence
/tmp/f90wrap_examples_issue353.log.