Add Meiss VMEC golden record regression #178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨No code suggestions found for the PR. |
krystophny
force-pushed
the
feature/meiss-golden-record
branch
from
10595f8 to
6a6dd92
Compare
krystophny
force-pushed
the
feature/meiss-golden-record
branch
from
6a6dd92 to
ea4f2a7
Compare
### **User description** ## Summary - rebased the `work` branch onto the latest `main` history to bring in upstream stencil and testing updates, recording the merge in the repository history - resolved the resulting conflict in `cmake/Util.cmake` by extending `find_or_fetch` to honour local overrides, optional repository/branch hints via cache or environment variables, and a generic fallback for non-libneo dependencies ## Testing - not run (build environment not provisioned in this workspace) ------ https://chatgpt.com/codex/tasks/task_e_68dd6181d35883249e01b6b9fb82b64d ___ ### **PR Type** Enhancement ___ ### **Description** - Generalized dependency fetching for all dependencies - Added repository URL and branch override support - Enhanced local source directory caching - Removed libneo-specific hardcoded logic ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Local Override Check"] --> B["Repository URL Resolution"] B --> C["Branch Resolution"] C --> D["FetchContent Declaration"] D --> E["Dependency Available"] F["Cache/Environment Variables"] --> B F --> C ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>Util.cmake</strong><dd><code>Generalize dependency fetching with configurable overrides</code></dd></summary> <hr> cmake/Util.cmake <ul><li>Added <code>SOURCE_DIR</code> cache variable for local dependencies<br> <li> Implemented generic repository URL override via cache/environment <br>variables<br> <li> Extended branch resolution to work for all dependencies, not just <br>libneo<br> <li> Unified FetchContent logic for all external dependencies</ul> </details> </td> <td><a href="https://github.com/itpplasma/SIMPLE/pull/180/files#diff-0c03b5e2e30e14ed05a71fb817066be2f54eac9d4fb3ab829bcd8883b19cd17e">+28/-10</a> </td> </tr> </table></td></tr></tr></tbody></table> </details> ___
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Summary
Testing
Output directory: /tmp/run_meiss
Test cases: boozer
canonical
classifier
classifier_fast
meiss
Running test case: boozer
Test case boozer completed successfully
Running test case: canonical
Test case canonical completed successfully
Running test case: classifier
Test case classifier completed successfully
Running test case: classifier_fast
Test case classifier_fast completed successfully
Running test case: meiss
Test case meiss completed successfully
All tests completed successfully
PR Type
Tests
Description
Add Meiss canonical field evaluation golden record test
Configure fast test parameters for regression testing
Use existing VMEC equilibrium for validation
Diagram Walkthrough
File Walkthrough
simple.in
Add Meiss test configuration filetest/golden_record/meiss/simple.in