Skip to content

Conversation

@prasad-sawantdesai
Copy link
Collaborator

@prasad-sawantdesai prasad-sawantdesai commented Jan 6, 2026

Cleanup: Remove IMAS availability checks from test fixtures #91

  • Removed has_imas and requires_imas fixtures from conftest.py since imas-core is now a mandatory dependency
  • Updated all test functions and fixtures that used requires_imas to remove the parameter
  • Simplified exception handling in conftest.py by removing defensive fallback code for ImasCoreBackendException since imas-core is always available

@maarten-ic maarten-ic linked an issue Jan 6, 2026 that may be closed by this pull request
Copy link
Collaborator

@maarten-ic maarten-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI has >100 failures and errors, can you have a look what's wrong and update the PR accordingly?

@prasad-sawantdesai
Copy link
Collaborator Author

CI has >100 failures and errors, can you have a look what's wrong and update the PR accordingly?

Yes, testing with MDSplus is skipped as imas_core Python package does not support the MDSplus backend.
https://github.com/iterorganization/IMAS-Python/pull/92/changes#diff-9d071ff1a106f23893c1e501b2bf7a51f40e33034917e60137e6655a2567b86e

Copy link
Collaborator

@maarten-ic maarten-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I also checked the remainder of conftest and there's some more pieces that can probably be removed. Could you have a look at those as well?

Copy link
Collaborator

@maarten-ic maarten-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, nice cleanup of the code! :)

@olivhoenen olivhoenen merged commit 28a35f7 into iterorganization:develop Jan 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup unit tests: remove checks for imas-core

4 participants