-
Notifications
You must be signed in to change notification settings - Fork 16
Cleanup unit tests: remove checks for imas-core #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup unit tests: remove checks for imas-core #92
Conversation
maarten-ic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI has >100 failures and errors, can you have a look what's wrong and update the PR accordingly?
Yes, testing with MDSplus is skipped as imas_core Python package does not support the MDSplus backend. |
maarten-ic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I also checked the remainder of conftest and there's some more pieces that can probably be removed. Could you have a look at those as well?
maarten-ic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, nice cleanup of the code! :)
Cleanup: Remove IMAS availability checks from test fixtures #91