Skip to content

Fix for Cyberark response casting error #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
privateip merged 3 commits into from
Nov 21, 2024
Merged

Fix for Cyberark response casting error #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
722c48b
added addition cyberark logging
Nov 18, 2024
4252249
fixed url
Nov 18, 2024
32d6d25
fixed response casting and private key file conditional
Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions plugins/lookup/cyberark_ccp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@
from ansible.plugins.lookup import LookupBase

from ansible_collections.itential.core.plugins.module_utils import http
from ansible_collections.itential.core.plugins.module_utils import display


PARAMETERS = frozenset((
Expand Down Expand Up @@ -181,20 +182,23 @@ def run(self, terms, variables, **kwargs):
certificate_file = kwargs.get("certificate_file")
private_key_file = kwargs.get("private_key_file")

if certificate_file is not None and private_key_file is None:
if certificate_file is not None and private_key_file is not None:
http_kwargs.update({
"certificate_file": certificate_file,
"private_key_file": private_key_file
})

display.vvvvv(f"url: {url}")
display.vvvvv(f"Request: {http_kwargs}")

resp = http.get(url, **http_kwargs)

try:
resp.raise_for_status()
except Exception as exc:
raise AnsibleError(str(exc))

content = resp.Json().get("Content")
content = resp.json().get("Content")
Copy link
Contributor

@steven-schattenberg-itential steven-schattenberg-itential Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! pylint doesn't pick this up either. Expensive typo...

if not content:
raise AnsibleError("error trying to retrieve password")

Expand Down