remove data encoding to json #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the logic to encode the payload before sending the request. This library should not attempt to infer the data type and simply add the data to the request exactly as it was passed to the function. It is the responsibility of the upstream function to call the function with the appropriately encoded data. This commit will now check if the value of data is type of bytes and raise an exception if it is not
privateip
force-pushed
the
remove-json-encoding
branch
from
27b00cb to
0e89cf3
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the logic to encode the payload before sending the request. This library should not attempt to infer the data type and simply add the data to the request exactly as it was passed to the function. It is the responsibility of the upstream function to call the function with the appropriately encoded data.