fix: Add missing token extraction in async OAuth authentication #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
privateip
commented
Dec 12, 2025
privateip
commented
- Extract access_token from OAuth response in AsyncAuthMixin.authenticate_oauth()
- Add token storage to self.token for subsequent authenticated requests
- Update test_async_authenticate_oauth_success to verify token extraction
- Add test_async_authenticate_oauth_no_access_token for missing token case
- Add test_async_authenticate_oauth_non_dict_response for invalid response case
- Update test_async_authenticate_oauth_path to properly mock response with token
- Extract access_token from OAuth response in AsyncAuthMixin.authenticate_oauth() - Add token storage to self.token for subsequent authenticated requests - Update test_async_authenticate_oauth_success to verify token extraction - Add test_async_authenticate_oauth_no_access_token for missing token case - Add test_async_authenticate_oauth_non_dict_response for invalid response case - Update test_async_authenticate_oauth_path to properly mock response with token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.