perf: Add caching to _get_loggers() function for improved performance #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
privateip
commented
Dec 12, 2025
privateip
commented
- Add @cache decorator to _get_loggers() function to avoid repeated logger dictionary iterations
- Add cache_clear() calls in set_level() when propagate=True to ensure current httpx loggers are included
- Add cache_clear() call in initialize() to ensure all current loggers are reset
- Update _get_loggers() docstring to document caching behavior and manual cache clearing
- Update test to clear cache when testing newly created loggers
- Add @cache decorator to _get_loggers() function to avoid repeated logger dictionary iterations - Add cache_clear() calls in set_level() when propagate=True to ensure current httpx loggers are included - Add cache_clear() call in initialize() to ensure all current loggers are reset - Update _get_loggers() docstring to document caching behavior and manual cache clearing - Update test to clear cache when testing newly created loggers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.