feat: Add thread-safe authentication locking to prevent race conditions #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
privateip
commented
Dec 12, 2025
privateip
commented
- Import threading and asyncio modules for lock implementations
- Add _auth_lock attribute to ConnectionBase initialization
- Initialize threading.Lock() in Connection.init() for sync operations
- Initialize asyncio.Lock() in AsyncConnection.init() for async operations
- Wrap authentication check in double-checked locking pattern
- Ensure only one thread/task authenticates during concurrent requests
- Import threading and asyncio modules for lock implementations - Add _auth_lock attribute to ConnectionBase initialization - Initialize threading.Lock() in Connection.__init__() for sync operations - Initialize asyncio.Lock() in AsyncConnection.__init__() for async operations - Wrap authentication check in double-checked locking pattern - Ensure only one thread/task authenticates during concurrent requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.