Feature/modify image #37
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added frequency dimension to the ImageData
…imensions between MRD and ISMRMRD format
johnstairs
reviewed
Nov 24, 2025
model/mrd_image.yml
Outdated
|
|
||
| # EDIT: Image Type. Used flags to allow requests for multiple types with one command. Added 'quantitative' types | ||
| ImageType: !enum | ||
| base: uint64 |
Contributor
There was a problem hiding this comment.
I suppose this should be a !flags instead of !enum
Contributor
Author
There was a problem hiding this comment.
This was an old comment, which will be fixed with the commit below, but we chose to set back to enum over flags.
We initially had flags as we assumed both the data type (e.g. real, imag, complex, etc.) and its interpretation types (e.g. T1map, T2map, etc.) had to be specified to recognize the image data. However, we discussed in the weekly meeting that the data types can be checked against the ImageData<T> data type. We can set a single enum of interpretation types as mutually exclusive.
…e misleading comment of flags
kekeke21
force-pushed
the
feature/modify_image
branch
from
36ad9e4 to
23415a6
Compare
… of ImageData - add NMR frequency label to ImageHeader as optional list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to suggest an image schema change that affects the current compatibility of the Image field with the ISMRMRD format.
ImageData: Increasedatadimension to 5d, (channel, z, y, x, frequency) to store spectroscopy dataImageHeader: AddimageTypeoptions to describe the meaning of the image, such as T1map, T2map. The current ImageType can conflict with the data type of ImageData, and we can discuss whether to isolate the data type and semantic type of image as fields. We considered putting the imagetype field as flags, so that data type of image and semantic type of image can be selected.ImageHeader: AddmeasurementFrequencyas an optional list of uint andmeasurementFrequencyLabelas an optional list of string to describe the frequency of each entries in the frequency dimension ofdata