-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
docs: clarify Routing.Type=custom as experimental #11111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+135
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reorganize Routing.Type section for clarity, group production and experimental options, consolidate DHT explanation, add limitations section to delegated-routing.md documenting that HTTP-only routing cannot provide content reliably
move DelegatedRouters after Type, add config option names to CAUTION headers
3 tasks
This was referenced Dec 16, 2025
Open
2color
reviewed
Dec 18, 2025
2color
reviewed
Dec 18, 2025
2color
reviewed
Dec 18, 2025
2color
reviewed
Dec 18, 2025
2color
reviewed
Dec 18, 2025
2color
reviewed
Dec 18, 2025
2color
reviewed
Dec 18, 2025
Member
2color
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but overall this is a welcome changed
gammazero
reviewed
Dec 18, 2025
This comment was marked as spam.
This comment was marked as spam.
- clarify that `auto` can be combined with custom URLs in `Routing.DelegatedRouters` - rename headers for consistency: `Routing.Routers.[name].Type`, `Routing.Routers.[name].Parameters`, `Routing.Methods` - replace deprecated Strategic Providing reference with `Provide.*` config - remove outdated caveat about 0.39 sweep limitation - wording: "likely suffer" → "will be most affected"
the IMPORTANT callout and Motivation section already cover what users need to know. historical version info was noise for researchers trying to configure custom routing. addresses reviewer feedback from #11111.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reorganize
Routing.Typesection for clarity, group production and experimental options, consolidate DHT explanation, addLimitationssection todelegated-routing.mddocumenting that HTTP-only routing cannot provide content reliably.PS. I'd like to congratulate myself on grabbing the PR number: