-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(tokens): add gray colors #30799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ionic-modular
Are you sure you want to change the base?
Changes from 73 commits
3192b29
0cc323a
d4a05e5
444c56a
0b4b461
6c31996
15870a9
3902e5d
db67416
fc40c77
9b0782c
50998a3
44aa9e8
42a1ecd
e20c7c0
c0b9385
1ac2ba8
fdefbe6
10d1e63
2637605
73b9b4f
5e5e883
e979f0e
9b2adaa
46dd76c
eda4918
a4cabf8
f330164
52b7eda
7a53b6d
98df565
048a263
c9cddad
826a7e4
16a10dd
307afa1
cedab14
1fae450
6ea3c81
5be9526
e692469
fb011cc
527af98
8149f95
a51ea42
10e091b
16f91ab
ec0bf01
00448f6
c3345d1
10eac37
70a1892
71fff87
a884809
161b46a
eb3c5a9
383d24c
0ce2e76
4b149a9
a193f0d
08e8349
b243e73
d1c5da7
c53560e
ee1d755
5732df1
75da67f
4652c37
91d4483
968782a
f0ee0b3
86972ec
cecc2a8
a926cd5
8af89c3
f0de6e0
0f4d7aa
fc94a0a
729566f
7db9e9c
4586638
6fe4734
cd4f3fd
d299976
b36d02d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ $action-sheet-ios-group-margin-top: 10px; | |
| $action-sheet-ios-group-margin-bottom: 10px; | ||
|
|
||
| /// @prop - Background color of the action sheet | ||
| $action-sheet-ios-background-color: $overlay-ios-background-color; | ||
| $action-sheet-ios-background-color: var(--ion-color-overlay-bg); | ||
|
|
||
| /// @prop - Border radius of the action sheet | ||
| $action-sheet-ios-border-radius: 13px; | ||
|
|
@@ -46,7 +46,7 @@ $action-sheet-ios-title-padding-bottom: 13px; | |
| $action-sheet-ios-title-padding-start: $action-sheet-ios-title-padding-end; | ||
|
|
||
| /// @prop - Color of the action sheet title | ||
| $action-sheet-ios-title-color: $text-color-step-600; | ||
| $action-sheet-ios-title-color: var(--ion-color-text-400); | ||
|
|
||
| /// @prop - Font size of the action sheet title | ||
| $action-sheet-ios-title-font-size: dynamic-font-min(1, 13px); | ||
|
|
@@ -115,10 +115,7 @@ $action-sheet-ios-button-background: linear-gradient( | |
| $action-sheet-ios-button-background-activated: $text-color; | ||
|
|
||
| /// @prop - Background color of the selected action sheet button | ||
| $action-sheet-ios-button-background-selected: var( | ||
| --ion-color-step-150, | ||
| var(--ion-background-color-step-150, $background-color) | ||
| ); | ||
| $action-sheet-ios-button-background-selected: var(--ion-components-ion-action-sheet-button-bg-selected); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I created a component variable here because the value changes based on palette. Light uses The same reasoning is applied to any other component variables seen in the other files. |
||
|
|
||
| /// @prop - Destructive text color of the action sheet button | ||
| $action-sheet-ios-button-destructive-text-color: ion-color(danger, base); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,8 +24,6 @@ | |
| font-size: 12px; | ||
| font-weight: normal; | ||
|
|
||
| color: var(--ion-color-step-600); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This wasn't being used. |
||
|
|
||
| margin-top: 10px; | ||
| margin-bottom: 5px; | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,5 +8,5 @@ | |
| } | ||
|
|
||
| :host button.ion-activated { | ||
| color: $text-color-step-400; | ||
| color: var(--ion-color-text-600); | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this so we can revisit this at the time of implementation. We might stick with this but still good to give it a second look.