Skip to content

Commit b158d6b

Browse files
committed
fix(messaging, android): properly remove remote message from prefs
previously the remove was not applied, so it likely never persisted to storage, leading to infinite growth and possible OOM
1 parent 038482e commit b158d6b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/messaging/android/src/main/java/io/invertase/firebase/messaging/ReactNativeFirebaseMessagingStoreImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public WritableMap getFirebaseMessageMap(String remoteMessageId) {
7373
@Override
7474
public void clearFirebaseMessage(String remoteMessageId) {
7575
UniversalFirebasePreferences preferences = UniversalFirebasePreferences.getSharedInstance();
76-
preferences.remove(remoteMessageId);
76+
preferences.remove(remoteMessageId).apply();
7777
// check and remove old notifications message
7878
String notificationIds = preferences.getStringValue(S_KEY_ALL_NOTIFICATION_IDS, "");
7979
if (!notificationIds.isEmpty()) {

0 commit comments

Comments
 (0)