Skip to content

Move response validation logic from middleware to validator classes #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geemus merged 1 commit into from
Jan 2, 2026
Merged

Move response validation logic from middleware to validator classes #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion lib/committee/schema_validator/hyper_schema/response_validator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def call(status, headers, data)
end

begin
if Committee::Middleware::ResponseValidation.validate?(status, validate_success_only)
if validate?(status)
if @link.is_a?(Drivers::OpenAPI2::Link)
raise InvalidResponse, "Invalid response.#{@link.href} status code #{status} definition does not exist" if @validators[status].nil?
if !@validators[status].validate(data)
Expand All @@ -73,6 +73,19 @@ def call(status, headers, data)
end
end

def validate?(status)
case status
when 204
false
when 200..299
true
when 304
false
else
!validate_success_only
end
end

private

def response_media_type(response)
Expand Down
15 changes: 14 additions & 1 deletion lib/committee/schema_validator/open_api_3/response_validator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,26 @@ def initialize(operation_wrapper, validator_option)
end

def call(status, headers, response_data, strict)
return unless Committee::Middleware::ResponseValidation.validate?(status, validate_success_only)
return unless validate?(status)

validator_options = { allow_empty_date_and_datetime: @allow_empty_date_and_datetime }

operation_wrapper.validate_response_params(status, headers, response_data, strict, check_header, validator_options: validator_options)
end

def validate?(status)
case status
when 204
false
when 200..299
true
when 304
false
else
!validate_success_only
end
end

private

attr_reader :operation_wrapper, :check_header
Expand Down