Add option to allow empty date and date-time strings

[zzak]

Depends on ota42y/openapi_parser#182.

I wasn't sure how to version guard this, but the tests pass using my branch. But this won't work without a version of openapi_parser which includes that option.

I chose to test the validation error message, but there weren't other examples like this in the code base so maybe unnecessary (testing the parser, not the tool). More just me making sure things were lined up properly.

[geemus]

Looks good overall, suggested a couple of fixes for the test names and a possible way to guard for backwards compatibility, let me know what you think. Thanks!

[zzak]

Hang on, I think we also need this in the response validator too.

Committee::InvalidResponse:
   #/components/schemas/Component/properties/originated_at Value: "" is not conformant with date-time format
 # lib/committee/schema_validator/open_api_3/operation_wrapper.rb:39:in `rescue in validate_response_params'
 # lib/committee/schema_validator/open_api_3/operation_wrapper.rb:34:in `validate_response_params'
 # lib/committee/schema_validator/open_api_3/response_validator.rb:20:in `call'
 # lib/committee/schema_validator/open_api_3.rb:46:in `response_validate'
 # lib/committee/test/methods.rb:40:in `assert_response_schema_confirm'
 # lib/committee/test/methods.rb:8:in `assert_schema_conform'

I'm looking into it, but I think we may need to patch openapi_parser again 😭

[zzak]

Ok, I've tested this with ota42y/openapi_parser#183 and everything is working now.

[geemus]

lgtm, thanks!

[geemus]

@zzak thanks again for working through that. Is that everything you needed to change? Do we just need a committee release now?

[zzak]

Thank you!! 🙇
Our tests are all passing with branches so I assume release shouldn't break anything. I will update it in my day tomorrow and let you know if anything goes wrong.

[geemus]

Sounds good.

Released v5.5.3

Just let me know if anything comes up.

[zzak]

🎉 Everything is working, thanks again for all your help!

[geemus]

Awesome, glad to hear it!