Add support for Hygon Platform QoS features #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Intel RDT spec[1] and AMD Platform QoS spec[2]: If the CPU platform supports CPUID.0FH.01H:EAX, CPUID.0FH.01H:EAX[7:0] returns MBM counter length (width) as offset from 24. But in hw_cap_mon_discover(), the MBM counter length is calculated with incorrect 7-bits bitmask (0x7f). Fix the issue with 8-bits bitmask (0xff) for MBM counter length. [1] Intel Architectures SDM, Vol.3B, 19.18 Intel RDT Monitoring: https://cdrdv2.intel.com/v1/dl/getContent/671200 [2] AMD Platform QoS Extensions, Rev 1.03: https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/other/56375_1_03_PUB.pdf Fixes: 050f8c6 ("lib: detect MBM counter length") Signed-off-by: Xiaochen Shen <shenxiaochen@open-hieco.net>
Hygon CPUs support Platform QoS features (PQoS Version V1.0) described in the AMD Platform QoS specification[1]. Following Platform QoS sub-features are available on Hygon CPUs if the underlying hardware supports it: - L3 Cache Occupancy Monitoring (CMT) - L3 External Memory Bandwidth Monitoring (MBM) - L3 Cache Allocation Enforcement (CAT) - Code and Data Prioritization (CDP) - Memory Bandwidth Enforcement/Allocation (MBA) [1] AMD Platform QoS Extensions, Rev 1.03: https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/other/56375_1_03_PUB.pdf Signed-off-by: Xiaochen Shen <shenxiaochen@open-hieco.net>
Add PQOS_VENDOR id Python interface for Hygon Platform QoS features. Signed-off-by: Xiaochen Shen <shenxiaochen@open-hieco.net>
The default base MBM counter length (width) is 24 bits. Currently, Hygon CPU does not support the CPUID 0xF.[ECX=1]:EAX to adjust the counter length. But the Hygon CPU supports wider counter with the fixed width of 32 bits. Set the default MBM counter length to 32 bit by adjusting the offset to 8 bits for Hygon. Hygon future products will implement CPUID 0xF.[ECX=1]:EAX. Signed-off-by: Xiaochen Shen <shenxiaochen@open-hieco.net>
|
Hi Xiaochen, |
Author
Hi Andrew, Note: Please help review #299 as well. The code base of this PR is on top of #299 which is a trivial bug fixing. Best regards, |
10 tasks
There was a problem hiding this comment.
Pull request overview
This PR adds Platform QoS (Quality of Service) feature support for Hygon CPUs, which implement AMD's PQoS specification v1.0. The changes enable the intel-cmt-cat library and utilities to recognize and handle Hygon processors alongside Intel and AMD processors.
Key changes:
- Introduces a new vendor identifier
PQOS_VENDOR_HYGONthroughout the codebase - Updates vendor detection logic to identify Hygon CPUs via CPUID signature
- Extends AMD-specific code paths to include Hygon, as Hygon follows AMD's PQoS specification
- Implements Hygon-specific counter length handling for monitoring capabilities
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/pqos.h | Adds PQOS_VENDOR_HYGON enum value and updates API documentation |
| lib/cpuinfo.c | Implements Hygon CPU detection and configuration initialization |
| lib/hw_cap.c | Adds Hygon-specific handling for monitoring counter length |
| lib/cap.c | Routes Hygon CPUs to AMD discovery functions for MBA capability |
| lib/api.c | Assigns AMD-specific MBA functions for Hygon vendor |
| lib/python/pqos/native_struct.py | Adds Python binding for PQOS_VENDOR_HYGON constant |
| lib/python/pqos/cpuinfo.py | Adds "HYGON" string mapping for vendor identification |
| pqos/alloc.c | Updates display logic to use AMD-style naming for Hygon |
| rdtset/rdt.c | Extends AMD-specific MBA and display logic to include Hygon |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Hygon Platform QoS features
Description
Hygon CPUs support Platform QoS features (PQoS Version V1.0) described
in the AMD Platform QoS specification.
The changes add Platform QoS features support for Hygon CPUs.
Affected parts
Motivation and Context
Add Platform QoS features support for Hygon CPUs.
Hygon CPUs support Platform QoS features (PQoS Version V1.0) described
in the AMD Platform QoS specification [1].
Following Platform QoS sub-features are available on Hygon CPUs if the
underlying hardware supports it:
[1] AMD Platform QoS Extensions, Rev 1.03:
https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/other/56375_1_03_PUB.pdf
How Has This Been Tested?
https://github.com/intel/intel-cmt-cat/wiki/Usage-Examples
Types of changes
Checklist: