[MBL-19148][Student] - Extend 'Ask Your Instructor' E2E test to check multiple teachers get the message #3478
Conversation
…ssage with multiple teachers. refs: MBL-19148 affects: Student release note: -
…eck-multiple-teachers-get-message
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR enhances the testHelpMenuAskYourInstructorMessage E2E test to verify that when a student uses "Ask Your Instructor", all instructors in the course receive the message individually (as separate conversations), not just the first one. This is a valuable test improvement that validates an important aspect of the messaging feature.
Positive Feedback
✅ Excellent test coverage expansion - The test now validates the multi-teacher scenario, which is a realistic use case
✅ Thorough verification - Checks both teachers receive messages individually and that conversations are properly isolated (teacher1 doesn't see teacher2's conversation and vice versa)
✅ Good test structure - The login/logout flow for switching between teachers is well-implemented
✅ Comprehensive assertions - Verifies recipients, subjects, and message content for both teacher perspectives
Issues to Address
- Variable naming clarity (line 554):
recipientListWithSecondTeachercould be clearer - these represent separate conversations, not cumulative recipients - Log message accuracy (line 556): Log states question is sent to "the instructor" (singular) but behavior now sends to all instructors
- Potential race condition (line 566): Asserting both conversations exist in sent folder - verify assertion methods handle async message delivery
Code Quality
The changes follow good testing practices with clear logging at each step. The test is well-structured and easy to follow. Minor improvements in naming and documentation would make this even better.
Test Coverage
Strong improvement in test coverage for the multi-instructor scenario. This will help catch regressions in the "Ask Your Instructor" feature's broadcast behavior.
Overall, this is a solid enhancement to the test suite. The inline comments contain specific suggestions for improvement.
apps/student/src/androidTest/java/com/instructure/student/ui/e2e/compose/InboxE2ETest.kt
Show resolved
Hide resolved
apps/student/src/androidTest/java/com/instructure/student/ui/e2e/compose/InboxE2ETest.kt
Show resolved
Hide resolved
apps/student/src/androidTest/java/com/instructure/student/ui/e2e/compose/InboxE2ETest.kt
Show resolved
Hide resolved
apps/student/src/androidTest/java/com/instructure/student/ui/e2e/compose/InboxE2ETest.kt
Show resolved
Hide resolved
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
🧪 Unit Test Results✅ 📱 Student App
✅ 📱 Teacher App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Wed, 14 Jan 2026 08:56:52 GMT |
|
Student Install Page |
|
Teacher Install Page |
…eck-multiple-teachers-get-message
kdeakinstructure
deleted the
MBL-19148-extend-ask-instructuro-e2e-to-check-multiple-teachers-get-message
branch
Extend testHelpMenuAskYourInstructorMessage E2E test with checking message with multiple teachers.
refs: MBL-19148
affects: Student
release note: -