[MBL-18125][Student] Add E2E test for custom reminders on assignments with no due date.

[adamNagy56]

Add E2E test for custom reminders on assignments with no due date.

refs: MBL-18125
affects: Student
release note:

Checklist

• Run E2E test suite

[claude]

Review Summary

This PR adds a new E2E test (testAssignmentNoDueDateCustomReminderE2E) that validates the assignment reminder functionality for assignments without due dates. The test covers important scenarios including adding custom reminders, preventing duplicate reminders, and validating invalid time inputs.

Positive Aspects

• Good test coverage for the no-due-date assignment reminder flow
• Includes edge cases like duplicate reminder prevention and invalid time validation
• Clear logging with step tags makes test execution easy to follow
• Properly structured test with appropriate assertions

Issues Found

• Calendar object mutation bug (lines 459, 482, 487): The test uses Calendar.apply { add(...) } which mutates the original futureDate object rather than creating independent instances. This causes reminderDate, reminderDate2, and futureDate to all reference the same mutated object, leading to unexpected behavior and making the test fragile.

• Unused mutation (line 482): futureDate.apply { add(Calendar.HOUR, 2) } modifies the object but doesn't assign the result, appearing to be orphaned code.

• Questionable invalid time test case (line 497): Using 00:00 (midnight) as the invalid time test case may not be ideal since midnight is typically a valid time. Consider using a truly invalid input or documenting why midnight is invalid for reminders.

Recommendations

1. Use futureDate.clone() as Calendar before applying modifications to create independent Calendar instances
2. Remove or clarify the purpose of the orphaned mutation on line 482
3. Consider using a more obviously invalid time input for the invalid time test case

The test logic is sound, but the Calendar handling needs to be fixed to prevent potential flakiness and confusion.

[github-actions]

🧪 Unit Test Results

✅ 📱 Student App

• Tests: 1241 total, 0 failed, 0 skipped
• Duration: 0.000s
• Success Rate: 100%

✅ 🌅 Horizon

• Tests: 490 total, 0 failed, 0 skipped
• Duration: 39.396s
• Success Rate: 100%

✅ 📦 Submodules

• Tests: 2556 total, 0 failed, 0 skipped
• Duration: 51.397s
• Success Rate: 100%

---

📊 Summary

• Total Tests: 4287
• Failed: 0
• Skipped: 0
• Status: ✅ All tests passed!

Last updated: Wed, 14 Jan 2026 08:28:26 GMT

[github-actions]

📊 Code Coverage Report

ℹ️ Student

• PR Coverage: 43.51%
• Master Coverage: N/A

ℹ️ Teacher

• PR Coverage: 25.61%
• Master Coverage: N/A

ℹ️ Pandautils

• PR Coverage: 22.91%
• Master Coverage: N/A

[github-actions]

Student Install Page