General Cleanup For Cocoapods #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twof
commented
Jan 7, 2019
twof
commented
- Added a license
- Bumped Swift version to 4.2
- Bumped iOS release version from 10.1 to 10.3
- All warnings silenced for cocoapods linter except from the tag requirement warning which will be fixed upon merge and tag
Updated fork to Swift 4
made changes to add xcode10 and swift 4.2 support
Fix/ios12
removed Redbooth remanents
cleanup for cocoapods release
radimhalfar
requested changes
Jan 18, 2019
Collaborator
radimhalfar
left a comment
radimhalfar
left a comment
There was a problem hiding this comment.
👏 Look good, please update minors and we can merge it
| case .aspectFit: previewLayer.videoGravity = AVLayerVideoGravity.resizeAspect | ||
| case .resize: previewLayer.videoGravity = AVLayerVideoGravity.resize | ||
|
|
||
| private func applyVideoDisplayMode() { switch displayMode { |
| @IBOutlet weak var imageView: UIImageView! | ||
|
|
||
| public final class ActionCell : UICollectionViewCell { | ||
|
|
Collaborator
There was a problem hiding this comment.
don't use extra opening lines
|
|
||
|
|
||
| public func setupOffsets() { | ||
| topOffset.constant = 5 |
Collaborator
There was a problem hiding this comment.
DRY, keep 5 to a constant
|
|
||
| durationLabel.textColor = UIColor.white | ||
| durationLabel.font = UIFont.systemFont(ofSize: 12, weight: .semibold) | ||
| durationLabel.font = UIFont.systemFont(ofSize: 12, weight: UIFont.Weight.semibold) |
|
|
||
| fileprivate var textAttributes: TextAttributes { | ||
| let activeFont = font ?? UIFont.systemFont(ofSize: 12, weight: .regular) | ||
| let activeFont = font ?? UIFont.systemFont(ofSize: 12, weight: UIFont.Weight.regular) |
|
|
||
| //perform update animations | ||
| collectionViewCoordinator.performChanges(changes, inSection: layoutConfiguration.sectionIndexForAssets) | ||
| collectionViewCoordinator.performChanges(changes as! PHFetchResultChangeDetails<PHObject>, inSection: layoutConfiguration.sectionIndexForAssets) |
Collaborator
There was a problem hiding this comment.
don't use force casts, rather assert it or guard it
|
|
||
| //update authorization status if it's changed | ||
| let status = AVCaptureDevice.authorizationStatus(for: .video) | ||
| let status = AVCaptureDevice.authorizationStatus(for: AVMediaType.video) |
| label.translatesAutoresizingMaskIntoConstraints = false | ||
| label.textAlignment = .center | ||
| label.numberOfLines = 0 | ||
| label.font = .systemFont(ofSize: 17, weight: UIFont.Weight.regular) |
| let button = UIButton(type: .system) | ||
| button.translatesAutoresizingMaskIntoConstraints = false | ||
| button.setTitle(NSLocalizedString("Go to Settings", comment: ""), for: .normal) | ||
| button.titleLabel?.font = .systemFont(ofSize: 20, weight: UIFont.Weight.semibold) |
| // } | ||
| // @available(iOS 11.0, *) | ||
| // func photoOutput(_ output: AVCapturePhotoOutput, didFinishProcessingPhoto photo: AVCapturePhoto, error: Error?) { |
Collaborator
There was a problem hiding this comment.
remove commented out code
Author
|
Thanks for your feedback! I no longer have edit access at the Redbooth org, so @lollar or Eli is going to have to fix this up. (Mike can you tag Eli? I don't remember his handle. Also feel free to reach out to me if you want help fixing this up.) |
- Updated all the plist settings w/ any new configs - Removed unnecessary / extra public function calls
Swift 5 upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.