fix bug where deleted binary files could not be retrieved #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is this intended as a short term workaround until we reimplement sync? If we don't load the DocHandle correctly if the file was deleted does that mean we also don't load it if the user replaced the binary file with another version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when we deleted a file, we would remove it from the "files" map in the branch doc entirely. This creates issues when you reload a project and try to revert to a commit where a deleted file was a linked binary file; since it wasn't in the "files" map, we don't retrieve the doc handle for it from the branch doc, and we have no ability to get that file. This changes it such that it retains the "url" and adds a "deleted" property to the files map if it's a binary file, so that we still see it when we retrieve the linked binary docs from the branch doc.