Evm wallet generation #3
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect EVM wallet derivation logic — now compatible with MetaMask/TrustWallet
Summary
The original
WalletManagerwas generating wallet data (mnemonic, private key, public key, address), but it wasn't EVM-compatible — meaning when importing the generated keys into services like MetaMask or TrustWallet, it would result in a different address or a failed import.Problem
What I Changed
HDWalletclass to handle BIP-44 derivation pathm/44'/60'/0'/0/0— the standard for Ethereum.KeyPair::fromMnemonic()logic to derive the correct private/public key pair and address.TestWallet.php) to demonstrate correct key generation and compatibility.Example Output (after fix)
Result
✅ Wallets generated from mnemonics are now: