Skip to content

Conversation

@teunmooij
Copy link
Collaborator

Fixes #19

By marking the type parameter in the dependsOn function typescript narrows we dependency, removing the need of marking it explicitely as const.

  • Tests pass
  • Appropriate changes to README are included in PR

@infinitas-cliftobot
Copy link

👋 Hi!

Sorry for interrupting your PR workflow, but we need your help!

We're busy updating the Infinitas Service Catalog so it contais a list of all the services we have at Infinitas and make them easily discoverable for everyone. You can find the catalog here in Notion.

The thing we're asking all repository contributors is to add a bit of metadata to your repository by adding a catalog-info.yaml to the root of each repository that we automatically index each night.

If you want to take a look at a working implementation, please check the eCommerce repo

Once the catalog file is added to the repo we'll promise to stop reminding you when creating new PR's.

Might you need any further assistance feel free to reach out to Clifton, Henk or Jerome.

And remember:

Please help out

@teunmooij teunmooij merged commit 7430aa0 into main Dec 8, 2024
1 check passed
@teunmooij teunmooij deleted the feat/19-dependsOn-narrowing branch December 8, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve narrowing of mapping dependency

2 participants