Skip to content

Conversation

@inducer
Copy link
Owner

@inducer inducer commented Apr 29, 2024

To get the tests in inducer/grudge#338 to go, zero-dimensional tensor product discretizations need to work. This bases_1d thing (which seems kind of ill-defined anyway) was an obstacle. It appeared entirely unused across meshmode and grudge.

@a-alveyblanc Do you have any objections to this?

@a-alveyblanc
Copy link
Contributor

a-alveyblanc commented Apr 29, 2024

This is necessary to get the 1D basis (bases) used to build the TP basis so that we can retrieve 1D operators.

inducer/grudge#313 depends on bases_1d for fast operator evaluation to work

(sorry if formatting is bad, I'm replying on GH mobile)

EDIT: From what I can tell by the changes, this can be worked around in inducer/grudge#313. Seems fine to merge.

@inducer
Copy link
Owner Author

inducer commented Apr 30, 2024

OK, thanks!

@inducer inducer merged commit 4cb7c84 into main Apr 30, 2024
@inducer inducer deleted the remove-bases-1d branch April 30, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants