Allow distributed partition boundaries to be not just rank boundaries #307

inducer · 2022-03-15T20:54:41Z

To do before merging:

Decide on Recast partition_mesh in terms of generic part identifiers #308
~~Decide on Add new helper for distributing data across MPI ranks #309~~ (we'll merge this separately)

inducer · 2022-03-17T16:34:15Z

I'll wait with merging this until we figure out what should happen to #308 and #309.

* simplify partition_mesh interface * add get_connected_partitions back to docs * use opaque partition ID instead of number in partition_mesh * use self/other instead of local/nonlocal * fix compatibility * remove unnecessary import Co-authored-by: Alex Fikl <alexfikl@gmail.com> * eliminate fun Co-authored-by: Alex Fikl <alexfikl@gmail.com> * stamp out remaining traces of fun * rename membership_list_to_sets -> membership_list_to_map and store index sets as numpy arrays instead of python sets * remove return_sets option from get_partition_by_pymetis * fix bugs in MPIBoundaryCommSetupHelper * flake8 * fix bug * add a couple of fixmes * handle groupless mesh case in dim/ambient_dim * Revert "handle groupless mesh case in dim/ambient_dim" not a good solution * disable removal of empty mesh groups in partitioning * fix some issues with partitioning docs * remove empty-group filtering * clarify part vs. partition terminology * change some asserts to exceptions * add a couple of FIXMEs * cosmetic change Co-authored-by: Andreas Klöckner <inform@tiker.net> * detect elements that belong to multiple parts * add return_parts argument to partition_mesh * add type hints to mesh partitioning * Fix some annotations in mesh.processing * add explicit part_id attribute to InterPartAdjacencyGroup * cosmetic change * fix some type annotations * Dict -> Mapping * fix outdated argument reference in docstring * try using just dtype dtype[Any] requires python 3.9 Co-authored-by: Alex Fikl <alexfikl@gmail.com> Co-authored-by: Andreas Klöckner <inform@tiker.net>

inducer · 2022-07-01T18:40:33Z

I think I've managed a clean rebase, there wasn't much to do. The diff between 4f7bc42 (prior state) and 28d2f34 (current state) is empty for me.

inducer · 2022-07-01T18:42:42Z

The flake8 failure seems to be due to a recent release of flake8-bugbear: https://pypi.org/project/flake8-bugbear/22.7.1/

majosm · 2022-07-01T18:53:52Z

The flake8 failure seems to be due to a recent release of flake8-bugbear: https://pypi.org/project/flake8-bugbear/22.7.1/

Yeah, getting some in grudge too:

grudge/trace_pair.py:434:28: B023 Function definition does not bind loop variable 'other_to_self'.
[80](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:81)
test/test_grudge.py:705:23: B023 Function definition does not bind loop variable 'v'.
[81](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:82)
test/test_grudge.py:705:32: B023 Function definition does not bind loop variable 'norm_v'.
[82](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:83)
test/test_grudge.py:705:43: B023 Function definition does not bind loop variable 'norm_v'.
[83](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:84)
test/test_grudge.py:717:47: B023 Function definition does not bind loop variable 'dcoll'.
[84](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:85)
test/test_grudge.py:726:20: B023 Function definition does not bind loop variable 'adv_operator'.
[85](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:86)
test/test_grudge.py:831:20: B023 Function definition does not bind loop variable 'maxwell_operator'.
[86](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:87)
test/test_grudge.py:917:24: B023 Function definition does not bind loop variable 'dcoll'.
[87](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:88)
test/test_euler_model.py:96:20: B023 Function definition does not bind loop variable 'euler_operator'.
[88](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:89)
test/test_op.py:70:22: B023 Function definition does not bind loop variable 'dcoll'.
[89](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:90)
test/test_op.py:72:55: B023 Function definition does not bind loop variable 'i'.
[90](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:91)
test/test_op.py:77:38: B023 Function definition does not bind loop variable 'dcoll'.
[91](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:92)
test/test_op.py:79:32: B023 Function definition does not bind loop variable 'i'.
[92](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:93)
test/test_op.py:80:28: B023 Function definition does not bind loop variable 'i'.
[93](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:94)
test/test_op.py:80:40: B023 Function definition does not bind loop variable 'i'.
[94](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:95)
test/test_op.py:81:24: B023 Function definition does not bind loop variable 'i'.
[95](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:96)
test/test_op.py:81:36: B023 Function definition does not bind loop variable 'i'.
[96](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:97)
test/test_op.py:81:67: B023 Function definition does not bind loop variable 'i'.
[97](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:98)
test/test_op.py:82:32: B023 Function definition does not bind loop variable 'i'.
[98](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:99)
test/test_op.py:83:28: B023 Function definition does not bind loop variable 'i'.
[99](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:100)
test/test_op.py:83:40: B023 Function definition does not bind loop variable 'i'.
[100](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:101)
test/test_op.py:84:24: B023 Function definition does not bind loop variable 'i'.
[101](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:102)
test/test_op.py:84:36: B023 Function definition does not bind loop variable 'i'.
[102](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:103)
test/test_op.py:100:32: B023 Function definition does not bind loop variable 'dcoll'.
[103](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:104)
test/test_op.py:109:31: B023 Function definition does not bind loop variable 'dcoll'.
[104](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:105)
test/test_op.py:109:42: B023 Function definition does not bind loop variable 'dd_allfaces'.
[105](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:106)
test/test_op.py:190:38: B023 Function definition does not bind loop variable 'dcoll'.
[106](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:107)
test/test_op.py:190:59: B023 Function definition does not bind loop variable 'i'.
[107](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:108)
test/test_op.py:192:55: B023 Function definition does not bind loop variable 'i'.
[108](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:109)
test/test_op.py:197:22: B023 Function definition does not bind loop variable 'dcoll'.
[109](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:110)
test/test_op.py:199:25: B023 Function definition does not bind loop variable 'dcoll'.
[110](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:111)
test/test_op.py:199:46: B023 Function definition does not bind loop variable 'i'.
[111](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:112)
test/test_op.py:200:32: B023 Function definition does not bind loop variable 'i'.
[112](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:113)
test/test_op.py:202:59: B023 Function definition does not bind loop variable 'i'.
[113](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:114)
test/test_op.py:203:32: B023 Function definition does not bind loop variable 'i'.
[114](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:115)
test/test_op.py:207:21: B023 Function definition does not bind loop variable 'dcoll'.
[115](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:116)
test/test_op.py:226:32: B023 Function definition does not bind loop variable 'dcoll'.
[116](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:117)
test/test_op.py:228:31: B023 Function definition does not bind loop variable 'dcoll'.
[117](https://github.com/inducer/grudge/runs/7155075955?check_suite_focus=true#step:4:118)
test/test_op.py:228:42: B023 Function definition does not bind loop variable 'dd_allfaces'.

😱

inducer · 2022-07-01T19:02:43Z

inducer/grudge#273

inducer · 2022-07-01T19:11:52Z

Thanks! In it goes.

This was referenced Mar 16, 2022

Recast partition_mesh in terms of generic part identifiers #308

Merged

Support multiple volumes in a discretization collection inducer/grudge#236

Closed

inducer force-pushed the generic-part-bdry branch 3 times, most recently from 16581c5 to 0ade9cc Compare March 17, 2022 05:45

inducer mentioned this pull request Mar 17, 2022

Add new helper for distributing data across MPI ranks #309

Closed

inducer force-pushed the generic-part-bdry branch from 0ade9cc to 697c371 Compare March 17, 2022 21:15

majosm force-pushed the generic-part-bdry branch from 3851911 to a27389c Compare April 12, 2022 04:13

inducer and others added 7 commits July 1, 2022 13:36

Add some type annotation in mesh.generation

9ec2544

Drop InterPartitionAdjacencyGroup.ineighbor_partition

5eb3640

MPI communication setup: Allow multiple boundaries per rank

68d7595

Add BoundaryTag type alias, annotate Mesh.groups

9314048

Add some more type annotations in mesh and discretization connection

ff7a730

Fix empty case of _compute_facial_adjacency_from_vertices

8744113

inducer force-pushed the generic-part-bdry branch from 4f7bc42 to 28d2f34 Compare July 1, 2022 18:39

Examine, silence new B023 bugbear warnings

39a7670

inducer enabled auto-merge (rebase) July 1, 2022 19:11

inducer merged commit ec31219 into main Jul 1, 2022

inducer deleted the generic-part-bdry branch July 1, 2022 19:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow distributed partition boundaries to be not just rank boundaries #307

Allow distributed partition boundaries to be not just rank boundaries #307

Uh oh!

inducer commented Mar 15, 2022 •

edited

Loading

Uh oh!

inducer commented Mar 17, 2022

Uh oh!

inducer commented Jul 1, 2022

Uh oh!

inducer commented Jul 1, 2022 •

edited

Loading

Uh oh!

majosm commented Jul 1, 2022

Uh oh!

inducer commented Jul 1, 2022

Uh oh!

inducer commented Jul 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Allow distributed partition boundaries to be not just rank boundaries #307

Allow distributed partition boundaries to be not just rank boundaries #307

Uh oh!

Conversation

inducer commented Mar 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

inducer commented Mar 17, 2022

Uh oh!

inducer commented Jul 1, 2022

Uh oh!

inducer commented Jul 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

majosm commented Jul 1, 2022

Uh oh!

inducer commented Jul 1, 2022

Uh oh!

inducer commented Jul 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

inducer commented Mar 15, 2022 •

edited

Loading

inducer commented Jul 1, 2022 •

edited

Loading