This repository was archived by the owner on Jun 14, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Semi-Implicit BDF/NDF #18
Draft
cmikida2
wants to merge
57
commits into
inducer:main
Choose a base branch
from
cmikida2:sbdf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
order convergence tests with Kaps problem
the CI (should that occur)
Owner
|
(Removed "WIP", marked as draft, added checkboxes for things needed to remove draft status.) |
Contributor
Author
|
@inducer I've just looked this over again and brought it up to speed with the main leap branch. It remains, as far as I can see, ready for a further look, or at the very least is in a good position for someone else to pick it up and make any further tweaks necessary. I'll also note that the previous failing CI issue, in which (by looking at previous workflows) the reactor test was failing deep in the guts of Jax somewhere, appears to have been dealt with via a202dcd. Additionally, I'll note that this PR depends upon/shares a decent amount of overlap with the work done in #17, and also depends upon this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extension of adaptive BDF/NDF (in the manner of CVODE) that introduces IMEX.
Needs:
requirements.txtback tomain