Modernize build setup and readme #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Grunt build tool and readme.txt - Add wp-env configuration for local development and testing - Update readme.md to match webmention plugin format - Update tested up to WordPress 6.9
- Update deploy.yml and update-assets.yml to use readme.md - Add path filter to update-assets.yml - Add SVN installation to phpunit workflow - Update actions/checkout to v4 - Clean up .distignore
- Add path filters to only run on relevant file changes - Add concurrency to cancel outdated workflow runs - Update actions/checkout to v4 - Limit push triggers to trunk branch - Fix phpunit job name (was incorrectly named phpcs) - Update PHP version to 8.2 for phpcs workflow
There was a problem hiding this comment.
Pull request overview
This PR modernizes the build and development workflow by removing the outdated Grunt-based build system and introducing wp-env for local development. The readme.txt file is removed in favor of readme.md as the primary readme, with the format updated to match the webmention plugin style.
- Replaces Grunt with @wordpress/env for local development and testing
- Removes readme.txt and updates readme.md with improved formatting and structure
- Updates "Tested up to" to WordPress 6.9 and adds PHP 8.5 to test matrix
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.txt | Removed entirely; readme.md is now the primary readme file |
| readme.md | Updated format with cleaner structure, reorganized sections, and updated compatibility version |
| package.json | Removed Grunt dependencies, added @wordpress/env, and added npm scripts for wp-env commands |
| Gruntfile.js | Removed as part of Grunt elimination |
| .wp-env.json | Added configuration for local WordPress environment with custom ports and test setup |
| .github/workflows/update-assets.yml | Updated to use readme.md and upgraded to actions/checkout@v4 |
| .github/workflows/phpunit.yml | Added PHP 8.5 and 8.4 to test matrix, upgraded to actions/checkout@v4, added SVN installation |
| .github/workflows/deploy.yml | Updated to use readme.md and upgraded to actions/checkout@v4 |
| .distignore | Reorganized to include package-lock.json and remove readme.md from ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing