Skip to content

Conversation

@RosaWagner
Copy link

@RosaWagner RosaWagner commented Jan 19, 2021

Hello!
I just added a config file for gftools builder and regenerated the fonts. This tool is so easy it makes me cry of joy every time.

  • Maybe you want to clean up all the build scripts, non of it is useful anymore.
  • You also just need gftools in the requirements.
  • See instructions below to add to your README.md

Installing the python packages in a virtual environment directly in your local repository:

  1. Open terminal
  2. Go to your local repo: $ cd path/to/Besley/local/repo
  3. Create a virtual env: $ python3 -m venv env
  4. Activate the virtual env: $ source env/bin/activate
  5. Install requirements: $ pip install -r requirements.txt

Building the fonts

  1. Go to your local repo and activate the virtual env
  2. Go to the sources directory: $ cd sources
  3. Build the entire family in all formats with one command 😭 🙏 : $ gftools builder config.yaml
  4. Find the fonts in the fonts directory !

use the command $ gftools builder --help for more informations.

@RosaWagner
Copy link
Author

Actually, the GDEF table needs to be fixed. It appears that you don't use combining accents, which are very useful to created non-encoded accented glyphs. So for example, you have to create the glyphs "acutecomb" (with proper anchor), and remove the anchor from the glyphs "acute". And you need to do that for all accents (gravecomb, tildecomb etc).

@EwonRael
Copy link
Contributor

hmmm. I find this a confusing comment because as far as I know I'm using combining accents. For example when I look inside the "glyphs" file inside the Besley-Regular.ufo folder I see a file called "acutecomb.glif" and when I inspect the "aacute.glif" file in a text editor I see

<outline>
<component base="acutecomb" xOffset="143" yOffset="-460"/>
<component base="a"/>
</outline>

which makes me think it's using the acutecomb.

What am I getting wrong here?

@EwonRael
Copy link
Contributor

some of the combining accents aren't named anything fancy, like combining_comma_below is just named "uni0326" is this the problem?

@RosaWagner
Copy link
Author

I just looked the report, not the ufos, my apologies. The problem may be in the anchors only then: did you place your anchors in the comb accents or in the legacy accents? Legacy accents shouldn’t have anchors. Then maybe check if the glyphs named with « comb » do have the proper Unicode (in case there was a switch)

@RosaWagner
Copy link
Author

RosaWagner commented Feb 3, 2021

Maybe the error comes from fontmake, which doesn't recognise the anchor naming scheme of Fontforge
+not-comb-accents have anchors and they shouldn't

@EwonRael
Copy link
Contributor

EwonRael commented Feb 3, 2021

Yeah, honestly just link me a sil ufo that fontmake likes and I'll just try and emulate it. Hopefully will solve this

@RosaWagner
Copy link
Author

It is fixed in Bodoni if I recall correctly

@davelab6
Copy link

davelab6 commented Aug 7, 2022

Should this be closed? Were the integrated manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants