-
Notifications
You must be signed in to change notification settings - Fork 10
Ready for GF #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Ready for GF #11
Conversation
|
Actually, the GDEF table needs to be fixed. It appears that you don't use combining accents, which are very useful to created non-encoded accented glyphs. So for example, you have to create the glyphs "acutecomb" (with proper anchor), and remove the anchor from the glyphs "acute". And you need to do that for all accents (gravecomb, tildecomb etc). |
|
hmmm. I find this a confusing comment because as far as I know I'm using combining accents. For example when I look inside the "glyphs" file inside the Besley-Regular.ufo folder I see a file called "acutecomb.glif" and when I inspect the "aacute.glif" file in a text editor I see
which makes me think it's using the acutecomb. What am I getting wrong here? |
|
some of the combining accents aren't named anything fancy, like combining_comma_below is just named "uni0326" is this the problem? |
|
I just looked the report, not the ufos, my apologies. The problem may be in the anchors only then: did you place your anchors in the comb accents or in the legacy accents? Legacy accents shouldn’t have anchors. Then maybe check if the glyphs named with « comb » do have the proper Unicode (in case there was a switch) |
|
Maybe the error comes from fontmake, which doesn't recognise the anchor naming scheme of Fontforge |
|
Yeah, honestly just link me a sil ufo that fontmake likes and I'll just try and emulate it. Hopefully will solve this |
|
It is fixed in Bodoni if I recall correctly |
|
Should this be closed? Were the integrated manually? |
Hello!
I just added a config file for gftools builder and regenerated the fonts. This tool is so easy it makes me cry of joy every time.
gftoolsin the requirements.Installing the python packages in a virtual environment directly in your local repository:
$ cd path/to/Besley/local/repo$ python3 -m venv env$ source env/bin/activate$ pip install -r requirements.txtBuilding the fonts
$ cd sources$ gftools builder config.yamlfontsdirectory !use the command
$ gftools builder --helpfor more informations.