feat: impl obsv search for multiple term_id and term_value_id combos #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this pull is accepted, one can now search for the desired male flowers or dead larvae.
The API portion of this change is definitely up for discussion. I did not want to make a new query parameter that might conflict with the existing
term_idandterm_value_idparameters, so I made a new parameter to just change how we interpret them for this new mode of filtering… but I would suggest, if v2 API’s are still a thing, that theGET observationsendpoint be designed to enable more complex querying (with AND’s / OR’s) compared to the v1 counterpart. I understand it might not be possible to overhaul how querying for annotations is designed for the v1 endpoint without a lot of coordination by many parties.If #542 gets merged first and if desired, I can change the tests to not use fixtures.
Closes #237