feat: add SetQueryParamsFromValues and SetQueryParamsFromStruct methods #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive query parameter methods that support url.Values and struct conversion: Features Added: - SetQueryParamsFromValues: Direct configuration from url.Values map - SetQueryParamsFromStruct: Struct-to-query conversion using go-querystring - Support for complex data types including slices and nested structures - Seamless integration with existing query parameter methods Implementation: - request.go: Added request-level methods with proper error handling - client.go: Added client-level SetCommon* variants for default parameters - request_wrapper.go: Added global wrapper functions for request methods - client_wrapper.go: Added global wrapper functions for client methods - go.mod: Added github.com/google/go-querystring dependency Testing: - request_test.go: Comprehensive tests including slice handling - client_test.go: Client-level functionality tests - Full test coverage for parameter merging and override behavior API Consistency: - Maintains three-tier architecture (request/client/global) - Follows existing naming conventions and patterns - Preserves backward compatibility with all existing methods Use Cases: - Direct url.Values integration for library interoperability - Struct-based query parameters with url tags - Simplified workflow for go-querystring users - Enhanced developer experience with type-safe query building
Owner
|
PR is perfect, I didn't find anything to improve, so I merged it.I will add the relevant usage to the official documentation |
Owner
|
Released in v3.55.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive query parameter methods that support url.Values and struct conversion:
Features Added:
Implementation:
Testing:
This PR implements the feature requested in #461.