feat: separate offer delivery endpoints #260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coplat
changed the title
coplat
changed the title
coplat
changed the title
daniel-mader
reviewed
Jan 2, 2026
| "method": "GET", | ||
| "header": [], | ||
| "url": { | ||
| "raw": "{{HOST}}/v0/keys/list-all", |
Contributor
There was a problem hiding this comment.
I think some endpoints in this updated Postman collection are unrelated to the code changes in this PR, right?
daniel-mader
reviewed
Jan 2, 2026
| }, | ||
| "url": { | ||
| "raw": "{{HOST}}/v0/offers/send", | ||
| "raw": "{{HOST}}/v0/offers/send-offer-to-organization", |
Contributor
There was a problem hiding this comment.
This is a breaking change since the old endpoint (/offers/send) would not work any longer. The type of commit is thus not a refactor:, but a feat: (including a BREAKING CHANGE in the body).
daniel-mader
reviewed
Jan 2, 2026
| .route("/offers", post(offers).get(all_offers)) | ||
| .route("/offers/{offer_id}", get(offer)) | ||
| .route("/offers/send", post(send)), | ||
| .route("/offers/send-offer-to-individual", post(email_offer)) |
Contributor
There was a problem hiding this comment.
Slight inconsistency here between the endpoint names and the handler functions: you called it email_offer and not individual_offer (compared to organization_offer).
coplat
added
the
BREAKING CHANGE
coplat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Previously, the send offer endpoint was a singular endpoint with the delivery method specified within the body of the request.
In order to improve API clarity this PR adds:
POST/offers/send-offer-to-individualfor email delivery.POST/offers/send-offer-to-organizationfor organizational target_url delivery.BREAKING CHANGE
This PR deprecates the old
offers/sendendpoint.How the change has been tested
Updated Postman collection. Existing tests pass.
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.