Improve efficiency of fibonacci using closed form #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilantc
reviewed
Aug 18, 2019
| else { | ||
| return (fibonaci(n-1) + fibonaci(n-2)); | ||
| } | ||
| return(Math.pow((1+Math.sqrt(5))/2,n)-Math.pow((1-Math.sqrt(5))/2,n))/Math.sqrt(5); |
MoLow
approved these changes
Aug 18, 2019
MoLow
reviewed
Aug 18, 2019
| return (Math.pow((1+Math.sqrt(5))/2,n)-Math.pow((1-Math.sqrt(5))/2,n))/Math.sqrt(5); | ||
| } | ||
|
|
||
| console.log('num is', fibonaci(20)); |
Owner
There was a problem hiding this comment.
Please keep the PR's with minimal changes, if you think we should change this log please create a separate PR for it
@MoLow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the closed form of Fibonacci to improve efficiency and protect from stack overflow (not the website)
https://en.wikipedia.org/wiki/Fibonacci_number#Closed-form_expression
http://mathonline.wikidot.com/a-closed-form-of-the-fibonacci-sequence