Replace item #4
Open
Replace item #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added slots to _types.py
Improved replaceItem
Added replaceItem
fixed pos in world.py
Removed mistake
Removed mistakes
Removed mistakes
Removed mistakes
Fixed imports
Fixed coordinates
icezyclon
requested changes
May 26, 2024
Owner
icezyclon
left a comment
icezyclon
left a comment
There was a problem hiding this comment.
Sehr gut, hab alles getestet (Blocks und Entities) und es scheint mir alles gut zu funktionieren. Besonders die SLOT Variable finde ich sehr hilfreich, da mir mein autocomplete direkt vorschläg was ich brauche 👍
| "black", | ||
| ] | ||
|
|
||
| SLOTS: TypeAlias = Literal[ |
Owner
There was a problem hiding this comment.
Bitte Einzahl verwenden, also SLOT statt SLOTS.
| raise_on_error(response) | ||
|
|
||
| def replaceItem(self, pos: Vec3, slot: SLOTS, item: str, amount: int = 1, nbt: NBT | None = None) -> None: | ||
| if nbt is None: |
Owner
There was a problem hiding this comment.
Bitte hier nur kurz die position abrunden, falls jemand keine Ganzzahlige Position hineinreicht.
(also, vor dem if ein pos = pos.floor() oder so, sollte meistens keine Rolle spielen, aber war eine Idee, die ich gerade hatte
Owner
|
Bitte siehe meinen Kommentar in #5 wo ich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.