Check for null argument while bailing out #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udayanshevade
commented
Sep 2, 2020
| arguments[0] !== null && arguments[0].left !== undefined | ||
| ? arguments[0].left | ||
| : typeof arguments[0] !== 'object' | ||
| : arguments[0] === null || typeof arguments[0] !== 'object' |
Author
There was a problem hiding this comment.
Update: Checking against null and allowing it to be passed through to the original scroll function. If this isn't desirable I can revert it.
udayanshevade
commented
Sep 2, 2020
| arguments[0].left !== undefined | ||
| arguments[0] !== null && arguments[0].left !== undefined | ||
| ? arguments[0].left | ||
| : typeof arguments[0] !== 'object' |
Author
There was a problem hiding this comment.
I noticed that the browser implementation of window.scrollTo handles null, whereas this ternary excludes null and passes a default of scrollX or pageXOffset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #161: Adding a couple of quick checks wherever the original scroll functions are called to ensure properties on
arguments[0]aren't accessed if its value isnull, aftershouldBailOut(arguments[0])evaluates totrue.