Skip to content

Conversation

@dvdrhr
Copy link

@dvdrhr dvdrhr commented Feb 13, 2020

#150

works for me, tested in chrome, safari, edge, mobile chrome and mobile safari

@jeremenichelli
Copy link
Collaborator

jeremenichelli commented Feb 15, 2020

Thanks for the PR first of all.

I think this one is missing a couple of edge cases for example when an element forces the window plus its scrollable container to scroll, d.body is referenced in other cases. I'd recommend running your local build in the repository page to test each case.

I will try to take a further look to try to detect edge cases. But the change is pointing into the right direct and it does solve your reported case in the issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants