Include document info when creating page notes via experimental button #7477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have discovered that page notes created via the button rendered when
enableExperimentalNewNoteButtonistrue, do not include the document metadata, since the logic is not triggered in the guest document, as it happens with the regular page notes button or annotations and highlights created from the adder.This PR adds a new RPC message that can be used for the sidebar to request the guest document info on demand, allowing those page notes to properly include the document metadata.
Test steps
POST http://localhost:5000/api/annotationscall, and verify it includes alldocumentmetadata.mainbranch, thedocumentwill be "empty"TODO