Skip to content

Make Disqus work with Hydejack's color toggle and transfer animation #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felixnie wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make Disqus work with Hydejack's color toggle and transfer animation #355

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43eb488
Fixed the Disqus iframe transparency issue on some browsers
felixnie Jan 17, 2025
7acc0e4
Refined the Disqus config with additional parameter page.identifier
felixnie Jan 17, 2025
d81ba75
Fixed the light-dark switching functionality of Disqus to work with H…
felixnie Jan 17, 2025
5323c16
Let /path/ and /path point to the same page
felixnie Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions _includes/my-comments.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
{% assign disqus = site.disqus | default:site.disqus_shortname %}
{% if disqus %}

<!-- Fixing the Disqus iframe transparency issue on some browsers -->
<style>
:root {
color-scheme: light dark;
}
/* make sure Disqus iframe uses light mode */
iframe {
color-scheme: light;
}
</style>

<div id="disqus_thread"></div>
<noscript>Please enable JavaScript to view the <a href="https://disqus.com/?ref_noscript" rel="nofollow">comments powered by Disqus.</a></noscript>
<script>!function(w, d) {
Expand All @@ -10,15 +22,33 @@
config() {
this.page.url = w.location.href;
this.page.title = d.title;
this.page.identifier = w.location.pathname.replace(/\/$/,'');
},
});
} else {
w.disqus_config = function disqusConfig() {
this.page.url = w.location.href;
this.page.title = d.title;
this.page.identifier = w.location.pathname.replace(/\/$/,'');
};
w.loadJSDeferred(d.getElementById("_hrefDisqus").href + '/embed.js');
w.loadJSDeferred(d.getElementById("_hrefDisqus").href + 'embed.js');
}
}

d.addEventListener('hydejack-dark-mode-toggle', (e) => {
setTimeout(() => {
if (w.DISQUS) {
w.DISQUS.reset({
reload: true,
config: function () {
this.page.url = w.location.href;
this.page.title = d.title;
this.page.identifier = w.location.pathname.replace(/\/$/,'');
}
});
}
}, 500);
});

}(window, document);</script>
{% endif %}
{% endif %}