Use hfh's is_offline_mode helper #42657
Open
+22
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
winglian
reviewed
Dec 5, 2025
Comment on lines
-86
to
-92
| def is_offline_mode(): | ||
| # Import inside the function so test patches on `huggingface_hub.constants` are picked up. | ||
| from huggingface_hub import constants as hf_hub_constants | ||
|
|
||
| return hf_hub_constants.HF_HUB_OFFLINE | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Rather than forcing an upgrade to hfh 1.2.1, could a try/except ImportError be better and still maintain a separate definition here with a deprecation warning?
Contributor
Author
There was a problem hiding this comment.
This will be live in transformers v5 which is not out yet. I do think it's the best timing to bump huggingface_hub minimal version without damage (in practice v5 will bump huggingface_hub from 0.x to 1.x, so it doesn't matter much if it's 1.0 or 1.2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on huggingface/huggingface_hub#3593 (released in
v1.2.1).Nothing changes, just moves the helper to huggingface_hub for consistency.