[Ernie 4.5 Moe] Fix routing, weights, and update expectations
#42653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasqu
commented
Dec 5, 2025
Comment on lines
+169
to
+171
| mapping["ernie4_5_moe"] += [ | ||
| WeightRenaming("mlp.moe_statics.e_score_correction_bias", "mlp.gate.moe_statics.e_score_correction_bias") | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
This weight was missing
vasqu
commented
Dec 5, 2025
Comment on lines
-375
to
381
| router_logits = F.linear(hidden_states.float(), self.weight) | ||
| router_logits = F.softmax(router_logits, dim=1, dtype=torch.float) | ||
| router_top_value, router_indices = torch.topk(self.moe_statics(router_logits), self.top_k, dim=-1) | ||
| router_top_value = router_top_value / torch.clamp( | ||
| router_top_value.sum(dim=-1, keepdim=True), min=self.norm_min | ||
| routing_weights = F.softmax(router_logits, dim=1, dtype=torch.float) | ||
| _, selected_experts = torch.topk(self.moe_statics(routing_weights), self.top_k, dim=-1) | ||
| routing_weights = torch.gather(routing_weights, dim=-1, index=selected_experts) | ||
| routing_weights = routing_weights / torch.clamp( | ||
| routing_weights.sum(dim=-1, keepdim=True), min=self.norm_min | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This is the core where I messed up previously. Now generations are similar again. I could also generate same outputs with VL using this change.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Dec 5, 2025
| @slow | ||
| def test_model_21b_a3b_generation(self): | ||
| EXPECTED_TEXT_COMPLETION = "User: Hey, are you conscious? Can you talk to me?\nAssistant: I don't have consciousness in the way humans do. I'm a text-based AI created to process and generate responses based on patterns in data." # fmt: skip | ||
| EXPECTED_TEXT_COMPLETION = "User: Hey, are you conscious? Can you talk to me?\nAssistant: \nI don't have consciousness in the way humans do. I don't feel emotions, have thoughts, or experience awareness. However, I'm" # fmt: skip |
Collaborator
There was a problem hiding this comment.
can you add a fast test for this one as well as we seem to break it often
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: ernie4_5_moe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, discovered during ernie vl