Skip to content

qwen2 tok regression #42644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itazap wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

qwen2 tok regression #42644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/transformers/models/qwen2/tokenization_qwen2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ def __init__(
self._vocab = {
"<|endoftext|>": 0,
}
self._merges = merges if merges is not None else generate_merges(self._vocab)
if merges is not None:
self._merges = [tuple(merge) if isinstance(merge, list) else merge for merge in merges]
else:
self._merges = generate_merges(self._vocab)
Comment on lines +66 to +69
Copy link
Collaborator

@ArthurZucker ArthurZucker Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

42563 fixes it!


self._tokenizer = Tokenizer(
BPE(
Expand Down