fix: support tensor labels in DataCollatorWithFlattening #42620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #42502
This PR adds support for
torch.Tensorlabels inDataCollatorWithFlattening. Previously, the collator only worked with list labels and raised aTypeErrorwhen tensor labels were provided.Problem
When users passed
torch.Tensorobjects as labels toDataCollatorWithFlattening, it failed with:This happened because the collator used list concatenation (
+=) without checking if inputs were tensors.Solution
hasattr(obj, "tolist")input_idsandlabelsChanges Made
src/transformers/data/data_collator.py:DataCollatorWithFlattening.__call__()tests/trainer/test_data_collator.py:test_flattening_with_tensor_labels: Verifies tensor labels worktest_flattening_with_list_labels: Regression test for list labelsTesting
Before this PR ❌
After this PR ✅
Checklist